chore(DragDrop): deprecate in v6 by kmcfaul · Pull Request #10181 · patternfly/patternfly-react

Conversation

@kmcfaul

What: Closes #10096

@tlabaj Do we want to move any of the old DragDrop examples? Currently there are examples using the now deprecated DragDrop on DataList and DualListSelector (current and next). Should we move those onto DragDrop's React deprecated page now? We do have examples for DataList/DualListSelector using the newer DragDropSort but they only live on the React next demos page currently.

@patternfly-build

@kmcfaul kmcfaul linked an issue

Mar 20, 2024

that may be closed by this pull request

@tlabaj

@tlabaj Do we want to move any of the old DragDrop examples? Currently there are examples using the now deprecated DragDrop on DataList and DualListSelector (current and next). Should we move those onto DragDrop's React deprecated page now? We do have examples for DataList/DualListSelector using the newer DragDropSort but they only live on the React next demos page currently.

@kmcfaul Can we update those examples to use the new drag and drop? Or are you asking if the even belong in the examples pages to begin with?

@kmcfaul

@tlabaj Bit of both. We have updated examples for those two components already, but they currently live in the Drag and Drop page's demo tab. I mostly wonder if we want to move those old examples to the deprecated Drag and Drop page, and if we want to move the new examples to the respective component pages.

@kmcfaul

If we're not sure we can probably open a docs followup to update the documentation to let this PR in

@kmcfaul

Per working session discussion, I'm adding a deprecated flag to the current examples and opening #10196 to follow up updating the documentation with the new demos.

thatblindgeye

tlabaj

@patternfly-build

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.46
  • @patternfly/react-core@6.0.0-alpha.46
  • @patternfly/react-docs@7.0.0-alpha.48
  • @patternfly/react-drag-drop@6.0.0-alpha.27
  • demo-app-ts@5.1.1-alpha.45
  • @patternfly/react-table@6.0.0-alpha.46

Thanks for your contribution! 🎉