feat(Page,Drawer): core bump and updates by kmcfaul · Pull Request #10211 · patternfly/patternfly-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kmcfaul

Copy link

Contributor

@kmcfaul kmcfaul commented

Mar 27, 2024

edited

Loading

What: Closes #10203

  • Added div around page-main for page-main-container
  • Replaced noBackground with primary for DrawerContent and separated into a new enum.
  • Updated layout custom CSS and md with core bump
  • Updated core ver to 107
  • Added temp fix for tokens parsing

@patternfly-build

Copy link

Collaborator

patternfly-build commented

Mar 27, 2024

edited

Loading

Copy link

Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes CI LGTM 🚀

Copy link

Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@patternfly-build

Copy link

Collaborator

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.18
  • @patternfly/react-code-editor@6.0.0-alpha.48
  • @patternfly/react-core@6.0.0-alpha.48
  • @patternfly/react-docs@7.0.0-alpha.50
  • @patternfly/react-drag-drop@6.0.0-alpha.29
  • @patternfly/react-icons@6.0.0-alpha.18
  • @patternfly/react-integration@6.0.0-alpha.24
  • demo-app-ts@5.1.1-alpha.47
  • @patternfly/react-styles@6.0.0-alpha.18
  • @patternfly/react-table@6.0.0-alpha.48
  • @patternfly/react-tokens@6.0.0-alpha.18

Thanks for your contribution! 🎉

@kmcfaul kmcfaul linked an issue

Mar 28, 2024

that may be closed by this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Page - add container for main content area

5 participants

@kmcfaul @patternfly-build @wise-king-sullyman @mcoker @tlabaj