Home Original page

feat(Modal): promoted next version by thatblindgeye · Pull Request #10358 · patternfly/patternfly-react

@thatblindgeye

What: Closes #8078

Additional issues:

@patternfly-build

This was referenced

May 14, 2024

wise-king-sullyman

Eric Olkowski added 2 commits

June 4, 2024 09:07

kmcfaul

tlabaj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment. We should not be using the deprecated modal in our components or examples/demos. We can open a follow up issue for that.

import { AboutModalBoxBrand } from './AboutModalBoxBrand';
import { AboutModalBoxCloseButton } from './AboutModalBoxCloseButton';
import { AboutModalBox } from './AboutModalBox';
import { Modal, ModalVariant } from '../Modal';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using the new modal here. I am ok with follow up issue to do that, but it should be done for Beta.

Radio,
Popper
} from '@patternfly/react-core';
import { Modal as ModalDeprecated, ModalVariant as ModalVariantDeprecated } from '@patternfly/react-core/deprecated';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above here

<Button onClick={() => setIsModalOpen(true)}>Show Modal</Button>

<Modal
<ModalDeprecated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use new modal here.

@thatblindgeye

In regards to above, followup created for updating examples: #10363

tlabaj

@patternfly-build

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.66
  • @patternfly/react-core@6.0.0-alpha.66
  • @patternfly/react-docs@7.0.0-alpha.70
  • @patternfly/react-drag-drop@6.0.0-alpha.48
  • @patternfly/react-integration@6.0.0-alpha.33
  • demo-app-ts@5.1.1-alpha.65
  • @patternfly/react-table@6.0.0-alpha.66
  • @patternfly/react-templates@6.0.0-alpha.16

Thanks for your contribution! 🎉