fix(EmptyState): Removed export of Header and Icon subcomponents by thatblindgeye · Pull Request #10364 · patternfly/patternfly-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@thatblindgeye

Copy link

Contributor

What: Closes #10130

Additional issues:

@patternfly-build

Copy link

Collaborator

patternfly-build commented

May 14, 2024

edited

Loading

@thatblindgeye thatblindgeye requested review from a team, kmcfaul and tlabaj and removed request for a team

May 21, 2024 12:48
Copy link

Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the CI issue and conflict

@tlabaj tlabaj merged commit 0f81473 into patternfly:v6

Jun 5, 2024

@patternfly-build

Copy link

Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.64
  • @patternfly/react-core@6.0.0-alpha.64
  • @patternfly/react-docs@7.0.0-alpha.68
  • @patternfly/react-drag-drop@6.0.0-alpha.46
  • demo-app-ts@5.1.1-alpha.63
  • @patternfly/react-table@6.0.0-alpha.64
  • @patternfly/react-templates@6.0.0-alpha.14

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@tlabaj tlabaj Awaiting requested review from tlabaj tlabaj was automatically assigned from patternfly/react-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - [V6 Empty state] - We should not export the EmptyStateHeader and EmptyStateIcon

5 participants

@thatblindgeye @patternfly-build @wise-king-sullyman @kmcfaul @tlabaj