fix(Toolbar): update align prop type to alignEnd, alignStart by nicolethoen · Pull Request #10366 · patternfly/patternfly-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nicolethoen

Copy link

Contributor

@nicolethoen nicolethoen commented

May 14, 2024

edited

Loading

What: Closes #10343

I opened a code mod issue as well: patternfly/pf-codemods#639

@patternfly-build

Copy link

Collaborator

patternfly-build commented

May 14, 2024

edited

Loading

@nicolethoen nicolethoen force-pushed the fix_toolbar_alignment branch from 4e33ca6 to 3f66333 Compare

May 14, 2024 19:53

@nicolethoen nicolethoen linked an issue

May 14, 2024

that may be closed by this pull request

@nicolethoen nicolethoen requested review from a team, jessiehuff and wise-king-sullyman and removed request for a team

May 14, 2024 20:17

@wise-king-sullyman wise-king-sullyman merged commit 83db357 into patternfly:v6

May 15, 2024

@patternfly-build

Copy link

Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.57
  • @patternfly/react-core@6.0.0-alpha.57
  • @patternfly/react-docs@7.0.0-alpha.60
  • @patternfly/react-drag-drop@6.0.0-alpha.38
  • @patternfly/react-integration@6.0.0-alpha.28
  • demo-app-ts@5.1.1-alpha.56
  • @patternfly/react-table@6.0.0-alpha.57
  • @patternfly/react-templates@6.0.0-alpha.7

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

+1 more reviewer

@jessiehuff jessiehuff jessiehuff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aligning items in PF Toolbar does not seem to work

4 participants

@nicolethoen @patternfly-build @wise-king-sullyman @jessiehuff