feat(Page): rename 'header' prop to 'masthead' by adamviktora · Pull Request #10454 · patternfly/patternfly-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@adamviktora

Copy link

Contributor

@adamviktora adamviktora commented

May 28, 2024

edited

Loading

Closes #10368

Additional issues:
Codemod followup: patternfly/pf-codemods#651

@adamviktora adamviktora requested review from a team, kmcfaul and wise-king-sullyman and removed request for a team

May 28, 2024 09:53

@patternfly-build

Copy link

Collaborator

patternfly-build commented

May 28, 2024

edited

Loading

@adamviktora adamviktora force-pushed the page-rename-header branch from eafa63f to 89d87da Compare

May 28, 2024 10:00

@adamviktora adamviktora force-pushed the page-rename-header branch from 89d87da to b9c76e2 Compare

May 28, 2024 11:25

@adamviktora adamviktora linked an issue

May 28, 2024

that may be closed by this pull request

@tlabaj tlabaj merged commit 37dd6ad into patternfly:v6

Jun 4, 2024

@patternfly-build

Copy link

Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.62
  • @patternfly/react-core@6.0.0-alpha.62
  • @patternfly/react-docs@7.0.0-alpha.66
  • @patternfly/react-drag-drop@6.0.0-alpha.44
  • @patternfly/react-integration@6.0.0-alpha.32
  • demo-app-ts@5.1.1-alpha.61
  • @patternfly/react-table@6.0.0-alpha.62
  • @patternfly/react-templates@6.0.0-alpha.12

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul kmcfaul was automatically assigned from patternfly/react-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF6 Page: rename header prop to masthead.

5 participants

@adamviktora @patternfly-build @wise-king-sullyman @nicolethoen @tlabaj