feat(Button): add text wrapper, update icon usage by kmcfaul · Pull Request #10663

feat(Button): add text wrapper, update icon usage by kmcfaul · Pull Request #10663 · patternfly/patternfly-react

Conversation

What: Closes #10626

Updates Button such that all children will be wrapped by pf-v6-c-button__text, and whenever an icon is passed in that icon will be wrapped by pf-v6-c-button__icon (was previously for non-plain buttons, now applies to all button icons).
Updates usages of our Buttons to passing the icon prop instead of an icon child.
Updates DualListSelectorControl to have an icon prop that is passed through to the internal Button.
Updates snapshots.

This PR will be failing until #10661 is merged due to the core bump.

kmcfaul linked an issue

Jun 27, 2024

that may be closed by this pull request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to see the codemod for plain buttons to pass their children to icon prop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ran visual regression tests before/after this update and there were no differences other than demos that dynamically generate content on page render

Link to the backstop report - backstop-react-7.2.24.pdf