feat(Navigation): Penta updates for nav by tlabaj · Pull Request #9948 · patternfly/patternfly-react
What: Closes #9943
Also made updates to the Page component. There were references to tertiary nav. Updated them to refer to horizontal subnav.
tlabaj
marked this pull request as draft
tlabaj
marked this pull request as ready for review
This was referenced
Jan 9, 2024Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The horizontal subnav scroll buttons seem to be showing when they shouldn't, but other than that everything looks great to me!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have an extra divider in the expandable example, other than that, great work!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The flyout menu still uses the old styling but I think that's a part of Menu's css and not Nav's, through the pf-m-nav modifier on the Menu right? @mcoker / @mattnolting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters