@fengqi something wrong here. I've seen already these commits. also, try to make PR title more descriptive. also use Draft if the PR is not ready for merge, as it seems you have same commits here that are in the previous PR, so the previous one needs to be merged first so this can be rebased.

@fengqi please don't force push during review. use git fixup, otherwise I do not see differences with the previous changes, and have to do review from scratch.

you can rebase and force push after you've pushed fixup commit

also, leave note of each fix if it's part of the discussion, like:

• "fixed in COMMIT_HASH_OF_FIXUP_COMMIT"

please don't force push during review. use git fixup, otherwise I do not see differences with the previous changes, and have to do review from scratch.

you can rebase and force push after you've pushed fixup commit

also, leave note of each fix if it's part of the discussion, like:

ok

The recent commit are to fix the CS-Fixer error😂

@glensc Thank you for your reminder, I rarely contribute code publicly on Github, so many rules are not understood.
I have learned a lot by contributing code this time

@fengqi I think you've finished here (CI passes), so you can do the final rebase. or do you have anything else in todo?

also, while rebasing, update branch from origin:

This branch is out-of-date with the base branch
Merge the latest changes from 0.19.x into this branch.

GitHub suggests creating a merge commit, but in this repo, we prefer to rebase.

@glensc There is nothing todo, the rebase is complete

There are few more ✗'s in #320, if that's what you were attempting to solve here:

• Equalize data store backends #320

Searcher::getAll(direction) should already solved, others are used internally in our low frequency, i will solve it in my free time.

Updated the table, marked that hardcoded direction (#337) was solved via #436

Updated the table, marked that hardcoded direction (#337) was solved via #436

ok