Correctly expand CSS `border-width` property by rockwotj · Pull Request #68 · phax/ph-css
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 27
Merged
Correctly expand CSS border-width property#68
phax merged 1 commit intophax:masterfrom
rockwotj:patch-1
Correctly expand CSS border-width property#68
phax merged 1 commit intophax:masterfrom
rockwotj:patch-1
Conversation
Copy link
Contributor
rockwotj
commented
Jun 9, 2021
rockwotj
commented
According to https://developer.mozilla.org/en-US/docs/Web/CSS/border-width should support 2 value and 3 value variants and right now it doesn't.
According to https://developer.mozilla.org/en-US/docs/Web/CSS/border-width should support 2 value and 3 value variants and right now it doesn't.
Copy link
Owner
phax
commented
Jun 9, 2021
phax commented
Jun 9, 2021That's a tricky one, because it would also expand border-width: thick; to border-width: thick thick thick thick;
Copy link
Contributor Author
rockwotj
commented
Jun 9, 2021
rockwotj commented
Jun 9, 2021Isn't that the correct behavior? Chrome seems to tell me it is:
Copy link
Contributor Author
rockwotj
commented
Jun 9, 2021
rockwotj commented
Jun 9, 2021Today if I do: border-width: thick it gets expanded to border-width: thick 3px 3px 3px which seems wrong...
Copy link
Owner
phax
commented
Jun 9, 2021
phax commented
Jun 9, 2021Point taken 🤣
phax
merged commit
fe77328
into
phax:master
rockwotj
deleted the
patch-1
branch
Copy link
Owner
Are you having any more errors in the pipeline or can I build a 6.3.4 release? @rockwotj
Copy link
Contributor Author
rockwotj
commented
Jun 9, 2021
rockwotj commented
Jun 9, 2021No other errors at the moment, thanks!
Copy link
Owner
phax
commented
Jun 9, 2021
phax commented
Jun 9, 2021Great. Release 6.3.4 is on its way to Maven Central
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants