tests: make caddy_tests faster. by AlliBalliBaba · Pull Request #1823 · php/frankenphp
Navigation Menu
{{ message }}
php / frankenphp Public
- Notifications You must be signed in to change notification settings
- Fork 444
Merged
Conversation
Copy link Copy Markdown
Contributor
AlliBalliBaba
commented
Aug 23, 2025
AlliBalliBaba
commented
This PR makes tests fast by removing the 10s sleep added in #1540 😅
AlliBalliBaba commented Aug 23, 2025
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestAllCommonHeadersAreCorrect(t *testing.T) { |
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also moved this test to the phpheaders module since it won't break compilation anymore in go 1.25
AlliBalliBaba
changed the title
tests: Make caddy_tests faster.
tests: make caddy_tests faster.
alexandre-daubois approved these changes Aug 25, 2025
Copy link Copy Markdown
Member
alexandre-daubois
left a comment
alexandre-daubois
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🙂
dunglas approved these changes Aug 25, 2025
dunglas
deleted the
fix/slow-tests
branch
Copy link Copy Markdown
Member
dunglas
commented
Aug 25, 2025
dunglas commented
Aug 25, 2025Thanks!
AlliBalliBaba
mentioned this pull request
henderkes pushed a commit to static-php/frankenphp that referenced this pull request
Sep 11, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants