fix `frankenphp trust` failing because admin api isn't started #1846 by henderkes · Pull Request #1870 · php/frankenphp
Navigation Menu
{{ message }}
php / frankenphp Public
- Notifications You must be signed in to change notification settings
- Fork 444
Merged
fix frankenphp trust failing because admin api isn't started #1846#1870
fix frankenphp trust failing because admin api isn't started #1846#1870
Conversation
Copy link Copy Markdown
Contributor
henderkes
commented
Sep 11, 2025
henderkes
commented
closes #1846
update frankenphp trust command to start it before so the admin api call doesn't fail
I hope this is the right way to go about it, I couldn't find an alternative
henderkes
force-pushed
the
fix/trust
branch
2 times, most recently
from
3871412 to
c101d18
Compare
henderkes
force-pushed
the
fix/trust
branch
from
c101d18 to
7710ef9
Compare
dunglas approved these changes Sep 11, 2025
henderkes commented Sep 12, 2025
Copy link Copy Markdown
Contributor Author
henderkes
left a comment
henderkes
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mholt would this be acceptable?
package/debian/postinst.sh
Show resolved
Hide resolved
package/debian/postinst.sh Show resolved Hide resolved
Copy link Copy Markdown
Contributor Author
henderkes
commented
Sep 26, 2025
henderkes commented
Sep 26, 2025Can we get this merged before the rpm/deb package PR? I have tried this and it works reliably, although it takes like 3-5 seconds.
Copy link Copy Markdown
Member
dunglas
commented
Sep 27, 2025
dunglas commented
Sep 27, 2025Thanks!
henderkes
deleted the
fix/trust
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment