fix `frankenphp trust` failing because admin api isn't started #1846 by henderkes · Pull Request #1870 · php/frankenphp

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@henderkes

Copy link Copy Markdown

Contributor

closes #1846
update frankenphp trust command to start it before so the admin api call doesn't fail

I hope this is the right way to go about it, I couldn't find an alternative

@henderkes henderkes force-pushed the fix/trust branch 2 times, most recently from 3871412 to c101d18 Compare

September 11, 2025 12:04
Copy link Copy Markdown

Contributor Author

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mholt would this be acceptable?

mholt reacted with thumbs up emoji

@henderkes

Copy link Copy Markdown

Contributor Author

Can we get this merged before the rpm/deb package PR? I have tried this and it works reliably, although it takes like 3-5 seconds.

@dunglas dunglas merged commit 76511c2 into php:main

Sep 27, 2025

56 checks passed

@dunglas

Copy link Copy Markdown

Member

dunglas commented

Sep 27, 2025

Thanks!

@henderkes henderkes deleted the fix/trust branch

September 27, 2025 15:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installing rpm/deb package fails to install CA trust

2 participants

@henderkes @dunglas