fix: catches panic on invalid status code by AlliBalliBaba · Pull Request #1920 · php/frankenphp
Navigation Menu
{{ message }}
php / frankenphp Public
- Notifications You must be signed in to change notification settings
- Fork 444
Merged
alexandre-daubois merged 2 commits intomainfrom
Oct 16, 2025Merged
fix: catches panic on invalid status code#1920
alexandre-daubois merged 2 commits intomainfrom
fix: catches panic on invalid status code#1920
alexandre-daubois merged 2 commits intomainfrom
Conversation
Copy link Copy Markdown
Contributor
Fixes #1907 by avoiding this panic.
I actually like that go panics here, but there might be edge cases where PHP legitimately sends a wrong status code.
alexandre-daubois approved these changes Oct 14, 2025
Copy link Copy Markdown
Member
alexandre-daubois
left a comment
alexandre-daubois
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
dunglas reviewed Oct 14, 2025
frankenphp.go
Outdated
Show resolved
Hide resolved
frankenphp.go Outdated Show resolved Hide resolved
dunglas approved these changes Oct 16, 2025
alexandre-daubois approved these changes Oct 16, 2025
alexandre-daubois
deleted the
fix/catch-invalid-response-codes
branch
Copy link Copy Markdown
Member
alexandre-daubois
commented
Oct 16, 2025
alexandre-daubois commented
Oct 16, 2025Thanks Alexander!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants