fix: fail immediately on missing worker file by AlliBalliBaba · Pull Request #1963 · php/frankenphp
Navigation Menu
{{ message }}
php / frankenphp Public
- Notifications You must be signed in to change notification settings
- Fork 444
Merged
alexandre-daubois merged 2 commits intomainfrom
Nov 10, 2025Merged
fix: fail immediately on missing worker file#1963
alexandre-daubois merged 2 commits intomainfrom
fix: fail immediately on missing worker file#1963
alexandre-daubois merged 2 commits intomainfrom
Conversation
henderkes approved these changes Nov 8, 2025
Copy link Copy Markdown
Contributor
henderkes
left a comment
henderkes
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, won't spam logs with too many consecutive worker failures.
Copy link Copy Markdown
Member
dunglas
commented
Nov 8, 2025
dunglas commented
Nov 8, 2025Shouldn't we do that in the library directly?
Copy link Copy Markdown
Contributor
Shouldn't we do that in the library directly?
Wouldn't that incur a runtime cost? This only runs during Caddy startup.
Edit: wouldn't matter much, since it's only on restarts.
Copy link Copy Markdown
Contributor Author
AlliBalliBaba
commented
Nov 8, 2025
AlliBalliBaba commented
Nov 8, 2025Doing it like this seems cleanest to me since we just immediately return an error on Init() and don't have to panic.
dunglas approved these changes Nov 8, 2025
alexandre-daubois approved these changes Nov 10, 2025
alexandre-daubois
deleted the
fix/error-immediately-on-missing-worker
branch
Copy link Copy Markdown
Member
alexandre-daubois
commented
Nov 10, 2025
alexandre-daubois commented
Nov 10, 2025Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants