suggestion: tail latency with goSched by AlliBalliBaba · Pull Request #2033 · php/frankenphp

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@AlliBalliBaba

Copy link Copy Markdown

Contributor

Alternate implementation to #2016 that doesn't reduce RPS with lower amounts of threads

@AlliBalliBaba AlliBalliBaba mentioned this pull request

Nov 25, 2025
Copy link Copy Markdown

Member

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just put it at the top of servHttp()?

@AlliBalliBaba

Copy link Copy Markdown

Contributor Author

AlliBalliBaba commented

Nov 25, 2025

edited

Loading

The request might also get rejected, feels most appropriate right before the select that it's supposed to make more fair.

@dunglas dunglas merged commit dadeb5a into main

Nov 26, 2025

25 checks passed

@dunglas dunglas deleted the suggestion/dispatch-latency branch

November 26, 2025 17:33

@dunglas

Copy link Copy Markdown

Member

dunglas commented

Nov 26, 2025

Thank you, everyone, for figuring this out! Impressive teamwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

@withinboredom withinboredom withinboredom approved these changes

@henderkes henderkes henderkes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlliBalliBaba @dunglas @withinboredom @henderkes