fix: crash when using the logger outside of the a request context v2 by lobre · Pull Request #2089 · php/frankenphp
lobre
changed the title
fix: crash when using the logger outside of the a request context
fix: crash when using the logger outside of the a request context v2
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it even possible to have a context in the contextHolder without having a frankenphpContext? If not, I'd still prefer having the context inside of the frankenphpContext and removing the contextHolder to make this less confusing (not necessarily in this PR).
@AlliBalliBaba not it's not, but this would create a circular reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters