PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) by mrwogu · Pull Request #184 · php-opencloud/openstack
Build passed successfully for:
- 7.0
- 7.1
but i don't know why for 7.2 i've got php-cs-fixer sugesstions on files which i didn't touch.
Maybe you have to think about php-cs-fixer update (current version is: 1.11.8)
I think we definitely should update some out-of-date dependencies like php-cs-fixer. Don't mind if you can update php-cs-fixer in this PR as well.
Support for php 7.2 will result in a new major version since there are some BC breaks.
@mrwogu BaseObject sounds misleading to me, at least from a developers perspective, BaseObject often use in the context of an abstract class.
What about using StorageObject instead?
Ok, i've renamed from Object to StorageObject.
php-cs-fixer has been updated and works fine now.
Unfortunately, PHPUnit is also outdated and I had to update it to a new version.
Could you check these errors?
mrwogu
changed the title
PHP 7.2 Compatibility
PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit)
@haphan could you merge this into php-opencloud:php-7.2?
I also rebased my branch with master.
Great works @mrwogu but I think commits got messed up during rebase.
Can you try to rebase it again?
@mrwogu Awesome works! 🎸
I've made only minor improvements to the README and php-cs-fixer.
Branch 2.0 will now contain version 2.x and master for 3.x.
kslr
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters