Home Original page

add default value for getAttribute call in ContinueBreakInLoopRule by canvural · Pull Request #4552 · phpstan/phpstan-src

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@canvural

Copy link

Contributor

@canvural canvural marked this pull request as ready for review

November 12, 2025 23:57

@phpstan-bot

Copy link

Collaborator

This pull request has been marked as ready for review.

Copy link

Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a rough look thru the whole codebase for similar issues and couldn't find any other.

lgtm - thank you

@staabm

Copy link

Contributor

staabm commented

Nov 13, 2025

@canvural the referenced issue is also talking about continue, which likely needs another test and/or fix

canvural reacted with thumbs up emoji

@canvural

Copy link

Contributor Author

canvural commented

Nov 13, 2025

•

edited

Loading

@canvural the referenced issue is also talking about continue, which likely needs another test and/or fix

Good idea. Added with 969b9d8

@ondrejmirtes ondrejmirtes merged commit 954d68f into phpstan:2.1.x

Feb 9, 2026

112 checks passed

@ondrejmirtes

Copy link

Member

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staabm staabm staabm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Top-level break statement breaks the analysis

4 participants

@canvural @phpstan-bot @staabm @ondrejmirtes