chore: replace `utils-merge` dependency with `Object.assign()` by jonkoops · Pull Request #138 · pillarjs/router

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@jonkoops

Copy link

Contributor

Replaces the utils-merge dependency with the built-in Object.assign() method.

ex1st reacted with thumbs up emoji

@socket-security

Copy link

socket-security bot commented

Oct 27, 2024

edited

Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/utils-merge@1.0.1

View full report↗︎

@jonkoops jonkoops force-pushed the replace-utils-merge branch from 108deaf to 8c8a434 Compare

October 27, 2024 17:33
Copy link

Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Jon Koops <jonkoops@gmail.com>

@jonkoops jonkoops force-pushed the replace-utils-merge branch from 8c8a434 to d6058b7 Compare

December 2, 2024 09:24

@jonkoops

Copy link

Contributor Author

jonkoops commented

Dec 2, 2024

Did a rebase, the PR should be good to merge again.

@UlisesGascon UlisesGascon changed the title Replace utils-merge dependency with Object.assign() chore: replace utils-merge dependency with Object.assign()

Dec 20, 2024

@UlisesGascon UlisesGascon merged commit 8a7c46c into pillarjs:master

Dec 20, 2024

@jonkoops jonkoops deleted the replace-utils-merge branch

December 20, 2024 17:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkoops @UlisesGascon @bjohansebas