Fix misaligned slider marks with empty labels by terminalchai · Pull Request #3723 · plotly/dash

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@terminalchai

Summary

  • add an explicit height: 12px to .dash-slider-mark so empty labels keep the same mark box height as labeled marks
  • add an integration regression test covering the empty-string marks case from #3715

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add the slider mark height fix
    • add a regression test for empty mark labels
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Fixes #3715

@AnnMarieW

@AnnMarieW

Just needs a changelog entry