Update CI to use GitHub actions by LiamConnors · Pull Request #426

Update CI to use GitHub actions by LiamConnors · Pull Request #426 · plotly/graphing-library-docs

It looks good to me @LiamConnors . Should we ask someone from graphing library team to review that as well? Please squash / merge so we end up with one commit that is easy to revert down the road if needed :)

LiamConnors changed the title ~~Update ci to use GitHub actions~~ Update CI to use GitHub actions

Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions, but this looks good.

Comment on lines +36 to +38

		- name: Set up Mapbox token
		run: \|
		echo "token: ${{ secrets.MAPBOX_TOKEN }}" > _data/mapbox_token.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as is, but why make it a separate step?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt it was cleaner and easier to read to keep all these setup steps separate

Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>