Update GeoPandas example for geopandas 1.0+ by mosh3eb · Pull Request #5509 · plotly/plotly.py
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 2.8k
Conversation
The example was using the 'world' dataset which was removed in geopandas 1.0. Updated to use the geodatasets package for v1.0+ with a fallback to the old approach for older versions.
This keeps the example working across all geopandas versions.
Fixes #4778
Documentation PR
- I have seen the [doc/README.md](https://github.com/plotly/plotly.py/blob/main/doc/README.md) file.
- This change runs in the current version of Plotly on PyPI and targets the
doc-prodbranch OR it targets themainbranch. - If this PR modifies the first example in a page or adds a new one, it is a
pxexample if at all possible. - Every new/modified example has a descriptive title and motivating sentence or paragraph.
- Every new/modified example is independently runnable.
- Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized.
- Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible.
- The random seed is set if using randomly-generated data.
- New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets.
- Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations.
- Imports are
plotly.graph_objects as go,plotly.express as px, and/orplotly.io as pio. - Data frames are always called df.
-
fig = <something>is called high up in each new/modified example (eitherpx.<something>or make_subplots orgo.Figure). - Liberal use is made of
fig.add_*andfig.update_*rather thango.Figure(data=..., layout=...). - Specific adders and updaters like
fig.add_shapeandfig.update_xaxesare used instead of bigfig.update_layoutcalls. -
fig.show()is at the end of each example. -
plotly.plot()andplotly.iplot()are not used in any example. - Named colors are used instead of hex codes wherever possible.
- Code blocks are marked with
```python.
The example was using the 'world' dataset which was removed in geopandas 1.0. Updated to use the geodatasets package for v1.0+ with a fallback to the old approach for older versions. This keeps the example working across all geopandas versions. Fixes plotly#4778
Thanks for the contribution @mosh3eb , we'll take a look as soon as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters