Autofocus effect by abernier · Pull Request #192 · pmndrs/react-postprocessing
Navigation Menu
{{ message }}
pmndrs / react-postprocessing Public
- Notifications You must be signed in to change notification settings
- Fork 127
Merged
Autofocus effect#192
abernier merged 5 commits intopmndrs:masterfrom
Autofocus effect#192
abernier merged 5 commits intopmndrs:masterfrom
Conversation
Copy link Copy Markdown
Member
Note Merged
see<Autofocus>doc
Based on @ektogamat work and pmndrs/postprocessing DepthOfFieldEffect, <Autofocus> effect extends <DepthOfField> and drives its target.
autofocus-suzi-v2.mov
Demo here: https://codesandbox.io/s/dfw6w4?file=/src/Autofocus.tsx
- Documentation updated
- Ready to merge
abernier
force-pushed
the
abernier/autofocus
branch
from
7593ea8 to
a0702b8
Compare
Copy link Copy Markdown
Contributor
ektogamat
commented
Apr 30, 2023
ektogamat commented
Apr 30, 2023Great work my friend. Happy that this will become official 😊✌🏻
v1rtl reviewed Apr 30, 2023
src/Autofocus.tsx
Outdated
Show resolved
Hide resolved
src/Autofocus.tsx Outdated Show resolved Hide resolved
Copy link Copy Markdown
Member
v1rtl
commented
Apr 30, 2023
v1rtl commented
Apr 30, 2023Could you please add a page to docs/effects instead of README?
v1rtl approved these changes Apr 30, 2023
v1rtl
requested a review
from drcmda
abernier commented Apr 30, 2023
src/Autofocus.tsx
Show resolved
Hide resolved
src/Autofocus.tsx Show resolved Hide resolved
abernier
force-pushed
the
abernier/autofocus
branch
from
d8076d7 to
963ab96
Compare
Copy link Copy Markdown
Contributor
ektogamat
commented
Apr 30, 2023
ektogamat commented
Apr 30, 2023Can I help with something? Documentation maybe? I have no idea how to contribute hehehe. Just want to be useful if needed, okay? 🫶🏻
drcmda requested changes May 1, 2023
src/Autofocus.tsx
Show resolved
Hide resolved
src/Autofocus.tsx Show resolved Hide resolved
src/Autofocus.tsx
Outdated
Show resolved
Hide resolved
src/Autofocus.tsx Outdated Show resolved Hide resolved
src/Autofocus.tsx
Outdated
Show resolved
Hide resolved
src/Autofocus.tsx Outdated Show resolved Hide resolved
abernier added 4 commits
May 2, 2023 09:18
abernier
force-pushed
the
abernier/autofocus
branch
2 times, most recently
from
84be37b to
3ca723a
Compare
abernier
force-pushed
the
abernier/autofocus
branch
from
3ca723a to
ee87945
Compare
abernier
requested a review
from drcmda
abernier
marked this pull request as draft
abernier
marked this pull request as ready for review
abernier
merged commit
9d1f77e
into
pmndrs:master
Copy link Copy Markdown
github-actions
bot
commented
May 2, 2023
github-actions bot commented
May 2, 2023
github-actions
bot
added
the
released
label
Copy link Copy Markdown
Contributor
ektogamat
commented
May 2, 2023
ektogamat commented
May 2, 2023AMAZING WORK GUYS 👏🏻👏🏻👏🏻🫶🏻
abernier
deleted the
abernier/autofocus
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment