semantic-release by abernier · Pull Request #194 · pmndrs/react-postprocessing
Navigation Menu
{{ message }}
pmndrs / react-postprocessing Public
- Notifications You must be signed in to change notification settings
- Fork 127
Merged
Conversation
Copy link Copy Markdown
Member
v1rtl
commented
May 1, 2023
v1rtl commented
May 1, 2023why reset the version?
abernier
force-pushed
the
abernier/semantic-release
branch
from
ba431f9 to
fab7474
Compare
Copy link Copy Markdown
Member Author
why reset the version?
Semantic release takes care of updating the version just before publishing to NPM. There is no need to have it versioned in source code. Thanks to semantic-release, the version will already appear as the latest release:
This is also how it's done in drei and explained in more details here: https://semantic-release.gitbook.io/semantic-release/support/faq#why-is-the-package.jsons-version-not-updated-in-my-repository
abernier commented May 1, 2023
.node-version
Show resolved
Hide resolved
.node-version Show resolved Hide resolved
Copy link Copy Markdown
Member Author
I think I'm done.
We could safely merge it into master: it won't trigger a release since only chore: commit messages in this PR (only feat: or fix: will).
Once merged, we could check the new Build and Release to npm pipeline just succeeds (without publishing any new version)
drcmda
merged commit
3a9998a
into
master
Copy link Copy Markdown
Member
drcmda
commented
May 1, 2023
drcmda commented
May 1, 2023thanks @abernier !
v1rtl
deleted the
abernier/semantic-release
branch
Copy link Copy Markdown
github-actions
bot
commented
May 1, 2023
github-actions bot commented
May 1, 2023
github-actions
bot
added
the
released
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment