Home Original page

add warning for deprecated stages names by asottile · Pull Request #3312 · pre-commit/pre-commit

@asottile

@asottile enabled auto-merge

September 30, 2024 22:41

@asottile asottile deleted the warning-for-old-stage-names branch

September 30, 2024 22:48

ysndr added a commit to flox/flox that referenced this pull request

Nov 29, 2024 
For a while when we run the git hooks, on push and commit,
the following warning was displayed:

```
[WARNING] hook id `clang-format` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `clippy` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `nixfmt-rfc-style` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `rustfmt` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] top-level `default_stages` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
```

tl;dr; the `push` stage was renamed to `pre-push` in pre-commit `4.0.0`.

See also:
- <https://github.com/pre-commit/pre-commit/releases/tag/v4.0.0>
- <pre-commit/pre-commit#2732>
- <pre-commit/pre-commit#3312>

@ysndr ysndr mentioned this pull request

Nov 29, 2024

github-merge-queue bot pushed a commit to flox/flox that referenced this pull request

Dec 4, 2024 
For a while when we run the git hooks, on push and commit,
the following warning was displayed:

```
[WARNING] hook id `clang-format` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `clippy` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `nixfmt-rfc-style` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `rustfmt` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] top-level `default_stages` uses deprecated stage names (push) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
```

tl;dr; the `push` stage was renamed to `pre-push` in pre-commit `4.0.0`.

See also:
- <https://github.com/pre-commit/pre-commit/releases/tag/v4.0.0>
- <pre-commit/pre-commit#2732>
- <pre-commit/pre-commit#3312>