Mobkoi: Update endpoint by mbonnafon · Pull Request #4183 · prebid/prebid-server-java
Navigation Menu
{{ message }}
prebid / prebid-server-java Public
- Notifications You must be signed in to change notification settings
- Fork 232
Merged
CTMBNara merged 1 commit intoprebid:masterfrom
Sep 19, 2025Merged
CTMBNara merged 1 commit intoprebid:masterfrom
CTMBNara merged 1 commit intoprebid:masterfrom
Conversation
Copy link Copy Markdown
Contributor
🔧 Type of changes
- bid adapter update
🧠 Rationale behind the change
Our endpoint should now be pbs.mobkoi.com/bid/prebidserver.
🧪 Test plan
Endpoint is reachable:
(base) > $ curl -X POST -d '{}' https://pbs.mobkoi.com/bid {"error":"Bot traffic not allowed"}%
🏎 Quality check
- Are your changes following our code style guidelines?
- Are there any breaking changes in your code?
- Does your test coverage exceed 90%?
- Are there any erroneous console logs, debuggers or leftover code in your changes?
mbonnafon
marked this pull request as ready for review
Net-burst
requested a review
from AntoxaAntoxic
Copy link Copy Markdown
Collaborator
AntoxaAntoxic
commented
Sep 10, 2025
AntoxaAntoxic commented
Sep 10, 2025Hi @mbonnafon
There is another PR #4080 which also adds integrationType, but it has a different mapping. Could you double-check that PR and come up with the single correct version of the changes?
Thanks
mbonnafon
force-pushed
the
update-mobkoi-pbs-endpoint
branch
from
6c8d845 to
aab2009
Compare
Copy link Copy Markdown
Contributor Author
mbonnafon
commented
Sep 10, 2025
mbonnafon commented
Sep 10, 2025Hi @AntoxaAntoxic,
Thanks for catching that. I think you can close the other PR.
I've discussed with the team members, and we'll go for the simplest option.
That means:
- Updating domain to
pbs.mobkoi.com - Updating the path to
/bid/prebidserver(which is already implemented) and detecting the prebidserver source from the path instead of the bid request custom extension field integration type.
curl -X POST -d '{}' https://pbs.mobkoi.com/bid/prebidserver {"error":"Bot traffic not allowed"}%
This decision is reflected by aab2009
mbonnafon
changed the title
Mobkoi: Update endpoint and add integration type
Mobkoi: Update endpoint
AntoxaAntoxic
mentioned this pull request
5 tasks
AntoxaAntoxic approved these changes Sep 11, 2025
CTMBNara approved these changes Sep 15, 2025
Copy link Copy Markdown
Contributor Author
mbonnafon
commented
Sep 18, 2025
mbonnafon commented
Sep 18, 2025Hi @AntoxaAntoxic, @CTMBNara, do you know what the next steps are for a merge?
cross-repo-issue-creation
bot
mentioned this pull request
AntoxaAntoxic
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment