fix textToModel regression for space characters by skyash-dev · Pull Request #8429 · processing/p5.js
Navigation Menu
{{ message }}
processing / p5.js Public
- Notifications You must be signed in to change notification settings
- Fork 3.7k
Merged
perminder-17 merged 2 commits intoprocessing:dev-2.0from
Jan 20, 2026Merged
fix textToModel regression for space characters#8429
perminder-17 merged 2 commits intoprocessing:dev-2.0from
fix textToModel regression for space characters#8429
perminder-17 merged 2 commits intoprocessing:dev-2.0from
Conversation
Copy link
Contributor
skyash-dev
commented
Jan 20, 2026
skyash-dev
commented
Resolves #8428
Changes:
- Fixes a regression where
textToModel(' ')would throw instead of returning an empty geometry. - Restores the behavior from earlier 2.x versions by returning an empty
p5.Geometrywhen no contours are present. - Prevents crashes in sketches that include space characters (e.g. Typography 2.0 tutorial).
PR Checklist
-
npm run lintpasses - Inline reference is included / updated
- Unit tests are included / updated
skyash-dev and others added 2 commits
January 20, 2026 23:18perminder-17 approved these changes Jan 20, 2026
Copy link
Collaborator
perminder-17
left a comment
perminder-17
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
ksen0
added this to p5.js 2.x 🌱🌳
github-project-automation
bot
moved this to Completed
in p5.js 2.x 🌱🌳
ksen0
added this to the
2.3 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants