Check if labelvalues is in _metrics before deletion in MetricWrapperBase.remove() by GlorifiedPig · Pull Request #1077 · prometheus/client_python
Navigation Menu
{{ message }}
prometheus / client_python Public
- Notifications You must be signed in to change notification settings
- Fork 843
Merged
csmarchbanks merged 1 commit intoprometheus:masterfrom
Dec 6, 2024Merged
Conversation
Copy link
Contributor
GlorifiedPig
commented
Dec 3, 2024
GlorifiedPig
commented
Currently raises an error if labelvalues is not in _metrics. Since the labelvalues get removed anyways, there isn't really any point of this error, since we would want to assume that after running this function call labelvalues will not exist regardless of it existed beforehand or not.
Signed-off-by: GlorifiedPig <ryan@glorifiedstudios.com>
GlorifiedPig
force-pushed
the
master
branch
from
d97db41 to
a3ef4b4
Compare
csmarchbanks approved these changes Dec 6, 2024
Copy link
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable quality of life improvement. Thanks!
csmarchbanks
merged commit
92b2397
into
prometheus:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants