Improve Java properties lexer by jeanas · Pull Request #2404 · pygments/pygments
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 781
Merged
Improve Java properties lexer#2404
jeanas merged 1 commit intopygments:masterfrom
Improve Java properties lexer#2404
jeanas merged 1 commit intopygments:masterfrom
Conversation
Copy link
Contributor
jeanas
commented
Apr 5, 2023
jeanas
commented
Use special lexer rules for escapes; fixes catastrophic backtracking, and highlights them too. (Also change Operator to Punctuation for the key/value separator.)
Fixes #2356
jeanas
force-pushed
the
properties
branch
from
f5ee666 to
84ca38e
Compare
Copy link
Collaborator
Anteru
commented
Apr 15, 2023
Anteru commented
Apr 15, 2023The change looks good, but could you please elaborate why operator -> punctuation? = feels like an operator to me.
jeanas
mentioned this pull request
Use special lexer rules for escapes; fixes catastrophic backtracking, and highlights them too. Fixes pygments#2356
jeanas
force-pushed
the
properties
branch
from
84ca38e to
ce60712
Compare
Copy link
Contributor Author
jeanas
commented
Apr 17, 2023
jeanas commented
Apr 17, 2023Hmm, ok, convinced :) I've changed it back.
Anteru
self-requested a review
Anteru approved these changes Apr 17, 2023
jeanas
merged commit
fdf182a
into
pygments:master
jeanas
deleted the
properties
branch
Anteru
added this to the
2.15.1 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment