Add Generic.EmphStrong token by diskdance · Pull Request #2444 · pygments/pygments
neiljp added a commit to neiljp/zulip-terminal that referenced this pull request
Oct 4, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. Longer-term we should improve the pygments to urwid translation logic to allow these styles to work and an upgrade to later pygments versions, but for now this allows these themes to continue working as before. Fixes zulip#1431.
neiljp added a commit to zulip/zulip-terminal that referenced this pull request
Oct 4, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. Longer-term we should improve the pygments to urwid translation logic to allow these styles to work and an upgrade to later pygments versions, but for now this allows these themes to continue working as before. Fixes #1431.
rsashank pushed a commit to rsashank/zulip-terminal that referenced this pull request
Oct 21, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. Longer-term we should improve the pygments to urwid translation logic to allow these styles to work and an upgrade to later pygments versions, but for now this allows these themes to continue working as before. Fixes zulip#1431.
Subhasish-Behera pushed a commit to Subhasish-Behera/zulip-terminal that referenced this pull request
Oct 27, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. Longer-term we should improve the pygments to urwid translation logic to allow these styles to work and an upgrade to later pygments versions, but for now this allows these themes to continue working as before. Fixes zulip#1431.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 19, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Add method `translate_styles` that manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics`. Tests added. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 20, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Add method `translate_styles` that manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics`. Tests added. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 20, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Add method `translate_styles` that manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics`. Tests added. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 21, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Method `translate_styles` manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics` is there. Unpin Pygments from ~=2.15.1 to >=2.14.0. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 22, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Method `translate_styles` manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics` is there. Unpin Pygments from ~=2.15.1 to >=2.14.0. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 22, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Add method `translate_styles` that manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics`. Tests added. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 22, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Method `translate_styles` manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics` is there. Unpin Pygments from ~=2.15.1 to >=2.14.0. Fixes part of zulip#1434.
jrijul1201 added a commit to jrijul1201/zulip-terminal that referenced this pull request
Dec 22, 2023Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold strong' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. Add method `translate_styles` that manually converts the pygments `bold italic` style into the urwid-compatible `bold, italics`. Tests added. Fixes part of zulip#1434.
neiljp pushed a commit to jrijul1201/zulip-terminal that referenced this pull request
Jan 8, 2024Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold italic' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. This minimally handles spaces and the shortened `italic` in pygments styles, sufficient to resolve the current style issue. Note that other pygments styles in themes that we do not yet use may need additional translation or adjustment. Tests added. Fixes part of zulip#1434.
neiljp pushed a commit to jrijul1201/zulip-terminal that referenced this pull request
Jan 8, 2024Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold italic' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for zulip#1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in zulip#1433. This minimally handles spaces and the shortened `italic` in pygments styles, sufficient to resolve the current style issue. Note that other pygments styles in themes that we do not yet use may need additional translation or adjustment. Tests added. Fixes part of zulip#1434.
neiljp pushed a commit to zulip/zulip-terminal that referenced this pull request
Jan 8, 2024Pygments 2.16.0 introduced a style to support a combination of bold and italic styling in pygments/pygments#2444. Both of our gruvbox themes and the light native theme gain a 'bold italic' style via pygments as a result, which urwid fails to parse and blocks the application from loading. This work would represent a clean fix for #1431, which was temporarily fixed by pinning pygments at ~=2.15.1 in #1433. This minimally handles spaces and the shortened `italic` in pygments styles, sufficient to resolve the current style issue. Note that other pygments styles in themes that we do not yet use may need additional translation or adjustment. Tests added. Fixes part of #1434.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters