update to NestedText v3 by KenKundert · Pull Request #2459 · pygments/pygments
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 781
Merged
jeanas merged 5 commits intopygments:masterfrom
jeanas merged 5 commits intopygments:masterfrom
Conversation
Copy link
Contributor
KenKundert
commented
Jun 22, 2023
KenKundert
commented
This change update pygments support for NestedText from version 1.0 to version 3.0.
jeanas requested changes Jun 24, 2023
pygments/lexers/configs.py
Outdated
Show resolved
Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
pygments/lexers/configs.py
Outdated
Show resolved
Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
pygments/lexers/configs.py
Show resolved
Hide resolved
pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py
Outdated
Show resolved
Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
Copy link
Contributor
jeanas
commented
Jun 24, 2023
jeanas commented
Jun 24, 2023Please also add some tests for the new functionality.
Ken Kundert added 3 commits
June 25, 2023 09:36Copy link
Contributor Author
KenKundert
commented
Jun 25, 2023
KenKundert commented
Jun 25, 2023Thanks for your suggestions. They were very helpful. I think the overall result is much improved. I am done with my changes and I believe the pull request is now read to go.
jeanas requested changes Jun 26, 2023
Copy link
Contributor
jeanas
left a comment
jeanas
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, thanks. Still a few things to fix though.
pygments/lexers/configs.py
Show resolved
Hide resolved
pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py
Show resolved
Hide resolved
pygments/lexers/configs.py Show resolved Hide resolved
pygments/lexers/configs.py
Outdated
Show resolved
Hide resolved
pygments/lexers/configs.py Outdated Show resolved Hide resolved
Copy link
Contributor Author
KenKundert
commented
Jun 26, 2023
KenKundert commented
Jun 26, 2023I believe all the issues are now resolved.
jeanas approved these changes Jun 26, 2023
jeanas
merged commit
a1091c7
into
pygments:master
Copy link
Contributor
jeanas
commented
Jun 26, 2023
jeanas commented
Jun 26, 2023Thank you!
Copy link
Contributor Author
KenKundert
commented
Jun 26, 2023
KenKundert commented
Jun 26, 2023Thank you very much. I appreciate all of your help and patience.
Anteru
added this to the
2.16.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment