Add lexer for Soong (Android.bp) config files by JonathonReinhart · Pull Request #2659 · pygments/pygments

@JonathonReinhart

@JonathonReinhart

Hi @Anteru @jeanas, friendly ping! Is there anything I can do to advance this?

@Anteru

Just came back from travel, looking into this now.

@JonathonReinhart

Thanks @Anteru. I fixed up the check and regexlint errors.

Anteru

@JonathonReinhart

Thanks for the review, @Anteru! Your comment about whitespace helped me realize there was a deficiency in my previous version (multi-line lists weren't handled correctly). I've corrected this and added a test.

Please take another look!

jeanas

@JonathonReinhart

@JonathonReinhart

Thanks @jeanas. All comments have been resolved.

jeanas

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

copybara-service bot pushed a commit to pigweed-project/pigweed that referenced this pull request

Oct 23, 2024

@JonathonReinhart