Make # replacing more strict by serhiy-storchaka · Pull Request #115 · python/cherry-picker

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

Copy link

Member

Only replace "#" with "GH-" with the following conditions:

  • "#" is separated from the previous word
  • "#" is followed by at least 5-digit number that does not start with 0
  • the number is separated from the following word

Fixes #114.

Only replace "#" with "GH-" with the following conditions:
* "#" is separated from the previous word
* "#" is followed by at least 5-digit number that does not start with 0
* the number is separated from the following word

@serhiy-storchaka serhiy-storchaka merged commit 19634f2 into python:main

Feb 12, 2024

@serhiy-storchaka serhiy-storchaka deleted the replace-number-sign branch

February 12, 2024 21:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make # replacing more strict

3 participants

@serhiy-storchaka @JelleZijlstra @hugovk