Revert #102 after upstream fix by ezio-melotti · Pull Request #126 · python/cherry-picker
Navigation Menu
{{ message }}
python / cherry-picker Public
- Notifications You must be signed in to change notification settings
- Fork 47
Merged
Conversation
Copy link
Member
ezio-melotti
commented
May 14, 2024
ezio-melotti
commented
Due to an upstream issue, we had to skip CVE-2023-5752 to fix CI:
The issue has now been fixed and released in the actions/python-versions repo:
- fix: use
--upgraderather than--ignore-installedto upgrade pip actions/python-versions#268 - Use
--upgradeinstead of--ignore-installedto upgradepip. actions/python-versions#254
The actions/setup-python repo still doesn't have a release, even though the issue should be fixed:
Since there is no setup-python release yet, the CI for this PR might fail. I created it as a reminder to remove the skip and to test whether the issue is actually fixed.
ezio-melotti
added
the
github_actions
label
May 14, 2024
ezio-melotti
requested a review
from hugovk
Copy link
Member
Good to hear! Let's convert to draft until the next actions/setup-python release.
hugovk
marked this pull request as draft
ezio-melotti added 2 commits
June 30, 2024 17:57
ezio-melotti
marked this pull request as ready for review
Copy link
Member Author
ezio-melotti
commented
Jun 30, 2024
ezio-melotti commented
Jun 30, 2024Looks like this is working now. Unfortunately we had to add another --ignore in #129, so I'll create another PR for that.
hugovk approved these changes Jun 30, 2024
Copy link
Member
hugovk
left a comment
hugovk
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ezio-melotti
merged commit
788c96c
into
main
ezio-melotti
deleted the
revert-102
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment