Revert #102 after upstream fix by ezio-melotti · Pull Request #126 · python/cherry-picker

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ezio-melotti

Copy link

Member

Due to an upstream issue, we had to skip CVE-2023-5752 to fix CI:

The issue has now been fixed and released in the actions/python-versions repo:

The actions/setup-python repo still doesn't have a release, even though the issue should be fixed:

Since there is no setup-python release yet, the CI for this PR might fail. I created it as a reminder to remove the skip and to test whether the issue is actually fixed.

hugovk reacted with thumbs up emoji

@ezio-melotti ezio-melotti added the github_actions

Pull requests that update GitHub Actions code

label

May 14, 2024

@ezio-melotti ezio-melotti requested a review from hugovk

May 14, 2024 11:19

@hugovk

Copy link

Member

hugovk commented

May 14, 2024

edited

Loading

Good to hear! Let's convert to draft until the next actions/setup-python release.

ezio-melotti reacted with thumbs up emoji

@hugovk hugovk marked this pull request as draft

May 14, 2024 15:09

@ezio-melotti ezio-melotti marked this pull request as ready for review

June 30, 2024 09:05

@ezio-melotti

Copy link

Member Author

Looks like this is working now. Unfortunately we had to add another --ignore in #129, so I'll create another PR for that.

hugovk reacted with thumbs up emoji
Copy link

Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ezio-melotti ezio-melotti merged commit 788c96c into main

Jun 30, 2024

@ezio-melotti ezio-melotti deleted the revert-102 branch

June 30, 2024 09:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

github_actions

Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ezio-melotti @hugovk