Remove `setuptools` installation for `safety` 3 by ezio-melotti · Pull Request #128 · python/cherry-picker

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ezio-melotti

Copy link

Member

@ezio-melotti ezio-melotti commented

Jun 30, 2024

edited

Loading

While working on #127 I noticed this TODO:
# TODO: remove setuptools installation when safety==2.4.0 is released
We are currently running Safety v3.2.3, so this can be removed.

However, the tests are failing due to an unrelated security issue. See here for more info:

@ezio-melotti ezio-melotti added the dependencies

Pull requests that update a dependency file

label

Jun 30, 2024

@ezio-melotti ezio-melotti merged commit 3d4f082 into python:main

Jun 30, 2024

@ezio-melotti ezio-melotti deleted the rm-setuptools branch

July 1, 2024 07:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

dependencies

Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ezio-melotti @hugovk