gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows by zooba · Pull Request #102544 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Merged
gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows#102544
zooba merged 6 commits intopython:mainfrom
gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows#102544
zooba merged 6 commits intopython:mainfrom
Conversation
Copy link
Member
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting core review
label
zooba
added
the
🔨 test-with-buildbots
label
Mar 9, 2023Copy link
bedevere-bot
commented
Mar 9, 2023
bedevere-bot commented
Mar 9, 2023
bedevere-bot
removed
the
🔨 test-with-buildbots
label
Mar 9, 2023eryksun reviewed Mar 9, 2023
Modules/posixmodule.c
Outdated
Show resolved
Hide resolved
Modules/posixmodule.c Outdated Show resolved Hide resolved
zooba added 3 commits
March 9, 2023 15:59eryksun reviewed Mar 9, 2023
Modules/posixmodule.c
Outdated
Show resolved
Hide resolved
Modules/posixmodule.c Outdated Show resolved Hide resolved
eryksun reviewed Mar 10, 2023
Modules/posixmodule.c
Show resolved
Hide resolved
Modules/posixmodule.c Show resolved Hide resolved
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Copy link
Member Author
zooba
commented
Mar 10, 2023
zooba commented
Mar 10, 2023I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find 😉
Thanks for the review, as always. Really appreciate having you check this stuff out
zooba
merged commit
cb35882
into
python:main
bedevere-bot
removed
the
awaiting core review
label
zooba
deleted the
gh-102519
branch
Copy link
Contributor
eryksun
commented
Mar 10, 2023
eryksun commented
Mar 10, 2023I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find wink
I thought you weren't finished yet since the PR doesn't document the new functions in "Doc/library/os.rst".
Copy link
Member Author
zooba
commented
Mar 10, 2023
zooba commented
Mar 10, 2023Weird, I definitely wrote those docs... I wonder where they've gone
zooba
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment