bpo-34100: Partially revert merge_consts_recursive() by vstinner · Pull Request #10743 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
bpo-34100: Partially revert merge_consts_recursive()#10743
vstinner merged 2 commits intopython:masterfrom
vstinner:revert_merge_consts
bpo-34100: Partially revert merge_consts_recursive()#10743
vstinner merged 2 commits intopython:masterfrom
vstinner:revert_merge_consts
Conversation
Partically revert commit c2e1607 to fix a reference leak.
vstinner
requested a review
from methane
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
vstinner
added
skip news
and removed
awaiting merge
labels
methane approved these changes Nov 27, 2018
bedevere-bot
added
the
awaiting merge
label
Copy link Copy Markdown
Member
methane
commented
Nov 27, 2018
methane commented
Nov 27, 2018I'd like to leave some comment like // Limitation: We don't merge frozenset for now.
Copy link Copy Markdown
Member Author
vstinner
commented
Nov 27, 2018
vstinner commented
Nov 27, 2018I'd like to leave some comment like // Limitation: We don't merge frozenset for now.
I wrote a quick & dirty fix, just to repair the CI. I know that you will work hard to write a proper fix :-)
vstinner
merged commit
1005c84
into
python:master
bedevere-bot
removed
the
awaiting merge
label
vstinner
deleted the
revert_merge_consts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment