bpo-35416: Fix potential resource warnings in distutils by BoboTiG · Pull Request #10918 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
methane merged 2 commits intopython:masterfrom
Apr 8, 2019Merged
bpo-35416: Fix potential resource warnings in distutils#10918
methane merged 2 commits intopython:masterfrom
bpo-35416: Fix potential resource warnings in distutils#10918
methane merged 2 commits intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
Prevent file descriptor leaks in distutils.
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
BoboTiG
force-pushed
the
fix-resource-warning-unclosed-file-distutils
branch
from
2af99ff to
bbcfda4
Compare
Copy link Copy Markdown
Member
merwok
commented
Dec 20, 2018
merwok commented
Dec 20, 2018Thanks, this looks good!
There are a few instances of weird indentation (from before your patch), I would like to take the opportunity to clean them.
Copy link Copy Markdown
Contributor Author
BoboTiG
commented
Dec 20, 2018
BoboTiG commented
Dec 20, 2018Of course, go ahead :)
Or do you want me to do the clean?
Copy link Copy Markdown
Member
merwok
commented
Dec 20, 2018
merwok commented
Dec 20, 2018Easier if I do them! It could take me a couple weeks though.
Another PR with some of the fixes was just merged, so part of the codebase is already better.
Copy link Copy Markdown
Contributor Author
Good :)
serhiy-storchaka approved these changes Dec 20, 2018
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
methane
merged commit
58721a9
into
python:master
bedevere-bot
removed
the
awaiting merge
label
BoboTiG
deleted the
fix-resource-warning-unclosed-file-distutils
branch
merwok reviewed Apr 8, 2019
methane
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants