gh-111965: Use critical sections to make io.BufferedIOBase and its related classes thread safe by Mayuresh16 · Pull Request #112298 · python/cpython
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
@colesbury Can you please review this draft PR once to help me to understand the issue if any exists in my work?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally like a reasonable approach.
You will need to sign the CLA- You should make sure the build passes.
EDIT: Sorry - I see that you've already signed the CLA.
- You should make sure the build passes.
Yeah, contributing for the first time so had a struggle bit but it was fun to begin and understand build checks too ;)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, In the end, we should support getter/setter from AC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters