[3.12] gh-112358: Fix Python 3.12 regression with subclassing struct.Struct (GH-112424) by mdickinson · Pull Request #112426

[3.12] gh-112358: Fix Python 3.12 regression with subclassing struct.Struct (GH-112424) by mdickinson · Pull Request #112426 · python/cpython

Merged

mdickinson merged 2 commits intopython:3.12from

mdickinson:backport-9fe6034-3.12

Nov 27, 2023

Merged

[3.12] gh-112358: Fix Python 3.12 regression with subclassing struct.Struct (GH-112424)#112426
mdickinson merged 2 commits intopython:3.12from
mdickinson:backport-9fe6034-3.12

Conversation

Copy link

Member

mdickinson commented
Nov 26, 2023
•

edited by bedevere-app bot

Loading

Revert commit c8c0afc (PR GH-94532), which moved struct.Struct initialisation from Struct.__init__ to Struct.__new__. This caused issues with code in the wild that subclasses struct.Struct.. (cherry picked from commit 9fe6034)

Issue: struct.Struct inheritance with Python 3.12.0 #112358

[3.12] pythongh-112358: Fix Python 3.12 regression with subclassing s…

72d90d0

…truct.Struct. (pythonGH-112424)

Revert commit c8c0afc (PR pythonGH-94532),
which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`.
This caused issues with code in the wild that subclasses `struct.Struct`..
(cherry picked from commit 9fe6034)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>

bedevere-app bot added the awaiting core review label