Home Original page

gh-113884: Make queue.SimpleQueue thread-safe in --disable-gil builds by mpage · Pull Request #114161 · python/cpython

@bedevere-app bot mentioned this pull request

Jan 17, 2024

@mpage mpage marked this pull request as ready for review

January 17, 2024 01:21

erlend-aasland

colesbury

colesbury

@mpage mpage marked this pull request as draft

January 18, 2024 21:01

@mpage 

Methods on SimpleQueue are protected with the per-object lock.

@blurb-it @mpage

@erlend-aasland @mpage 

We're not using `PyThread_acquire_lock_timed`.

@mpage

colesbury

@mpage mpage marked this pull request as ready for review

January 19, 2024 23:53

@mpage

erlend-aasland

erlend-aasland

@erlend-aasland

erlend-aasland

@erlend-aasland 

Rename parking lot callback to better reflect what it does.
More precise type for whether handoff occurred.

erlend-aasland

@mpage mpage deleted the gh-113884-ft-simplequeue branch

January 29, 2024 18:06

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024 
…isabled (python#114161)

* use the ParkingLot API to manage waiting threads
* use Argument Clinic's critical section directive to protect queue methods
* remove unnecessary overflow check

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

kumaraditya303

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024 
…isabled (python#114161)

* use the ParkingLot API to manage waiting threads
* use Argument Clinic's critical section directive to protect queue methods
* remove unnecessary overflow check

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>