bpo-35685: Add examples of unittest.mock.patch.dict usage by eamanu ยท Pull Request #11456 ยท python/cpython

@eamanu

Add examples of the use of mock.path.dict with decorator and in class. Currently there are examples only with the use on context manager.

https://bugs.python.org/issue35685

@eamanu

tirkarthi

@terryjreedy

Tracker issues are more visible than PRs and more likely to get the attention of a core dev who can review and merge. Michael Foord is the listed expert for unittest.mock, but does not have a listed GitHub account and therefore is inactive. I am not an expert on either unittest or rst and have a backlog of IDLE PRs to review, so I will have to pass.

@eamanu

Tracker issues are more visible than PRs and more likely to get the attention of a core dev who can review and merge. Michael Foord is the listed expert for unittest.mock, but does not have a listed GitHub account and therefore is inactive. I am not an expert on either unittest or rst and have a backlog of IDLE PRs to review, so I will have to pass.

Thanks for the response. I will open a issue on bugs.python

@eamanu eamanu changed the title Doc: Add samples on patch.dict of the use of decorator and in class bpo-35685: Add samples on patch.dict of the use of decorator and in class

Jan 8, 2019

berkerpeksag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for wanting to improve our documentation! :) I just left some comments.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eamanu

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eamanu

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@merwok merwok changed the title bpo-35685: Add samples on patch.dict of the use of decorator and in class bpo-35685: Add examples of unittest.mock.patch.dict usage

Jan 11, 2019

@eamanu

@eamanu

I have made the requested changes; please review again

@bedevere-bot

@JulienPalard

I rebased on top of master because another commit (0453081) introduced a versionchanged that would be misplaced if I let github merge it.

JulienPalard

berkerpeksag

@miss-islington

Thanks @eamanu for the PR, and @JulienPalard for merging it ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.8.
๐Ÿ๐Ÿ’โ›๐Ÿค–

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 12, 2019
โ€ฆ1456)

(cherry picked from commit 31a82e2)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>

@bedevere-bot

miss-islington added a commit that referenced this pull request

Sep 12, 2019
(cherry picked from commit 31a82e2)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>