Home Original page

[2.7] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff by CuriousLearner · Pull Request #11482 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@CuriousLearner

Copy link Copy Markdown

Member

@CuriousLearner CuriousLearner commented

Jan 9, 2019

•

edited by bedevere-bot

Loading

CuriousLearner and others added 2 commits

January 9, 2019 23:46
… diff (pythonGH-10639).

(cherry picked from commit cbb1645)

Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>

@CuriousLearner

Copy link Copy Markdown

Member Author

Hi @orsenthil

Can you please have a look at this one?

Copy link Copy Markdown

Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit 02e33d9 into python:2.7

Jan 9, 2019

@bedevere-bot

Copy link Copy Markdown

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@orsenthil

Copy link Copy Markdown

Member

Thanks again, @CuriousLearner !

@CuriousLearner

Copy link Copy Markdown

Member Author

Thanks to you @orsenthil :)

I was waiting for my PRs to be reviewed for so long.

Many thanks! 🌮

orsenthil added a commit that referenced this pull request

Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CuriousLearner @bedevere-bot @orsenthil @the-knights-who-say-ni