[3.7] Revert "bpo-24746: Avoid stripping trailing whitespace in doctest fan… by vstinner · Pull Request #11498 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

vstinner wants to merge 1 commit intopython:3.7from

vstinner:revert_doctest37

Closed

[3.7] Revert "bpo-24746: Avoid stripping trailing whitespace in doctest fan…#11498

vstinner wants to merge 1 commit intopython:3.7from

vstinner:revert_doctest37

Conversation

@vstinner

Copy link Copy Markdown

Member

@vstinner vstinner commented

Jan 10, 2019

edited by bedevere-bot

Loading

…cy diff (GH-10639)"

This reverts commit 53cf5f0.

https://bugs.python.org/issue24746

pablogsal

pablogsal previously approved these changes Jan 10, 2019

@pablogsal pablogsal dismissed their stale review

January 10, 2019 11:23

I have made a fix in #11501 for this issue so this should not be needed.

@eamanu

Copy link Copy Markdown

Contributor

eamanu commented

Jan 10, 2019

I agree with @pablogsal. The PR #11501 seems be more simple

@vstinner

Copy link Copy Markdown

Member Author

Abandonned since PR #11501 has been merged.

@vstinner vstinner closed this

Jan 10, 2019

@vstinner vstinner deleted the revert_doctest37 branch

January 10, 2019 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @eamanu @pablogsal @the-knights-who-say-ni @bedevere-bot