ghost changed the title bpo-34294: in re module, reset state when must_advance bpo-34294: in re module, fix wrong capturing groups when advancing inside a match

ghost changed the title bpo-34294: in re module, fix wrong capturing groups when advancing inside a match bpo-34294: in re module, fix wrong capturing groups when advancing inside a search

ghost changed the title bpo-34294: in re module, fix wrong capturing groups when advancing inside a search bpo-34294: in re module, fix wrong capturing groups when must_advance attempt fails.

ghost changed the title bpo-34294: in re module, fix wrong capturing groups when must_advance attempt fails. bpo-34294: in re module, fix wrong capturing groups in SRE(search) function.

Need to reset capturing groups between two `SRE(match)` callings in loops, this fixes wrong capturing groups in rare cases.

Other changes in this commit:
* Emit `SRE_ERROR_STATE` when reach impossible code path, rather than return a match failure silently.
* Add two test-cases to `test_zerowidth()`.
* Add a missing index in `re.rst`.
* Remove an outdated FIXME comment in `_sre.c`.

miss-islington added a commit that referenced this pull request

…1546)

Need to reset capturing groups between two SRE(match) callings in loops, this fixes wrong capturing groups in rare cases.

Also add a missing index in re.rst.
(cherry picked from commit 4a7f44a)

Co-authored-by: animalize <animalize@users.noreply.github.com>

ghost mentioned this pull request