gh-112087: Make list_{subscript, ass_slice, slice} to be thread-safe by corona10 · Pull Request #115854 · python/cpython
Conversation
Copy link Copy Markdown
Member
corona10 added 2 commits
February 22, 2024 00:44
bedevere-app
bot
added
the
awaiting core review
label
bedevere-app
bot
mentioned this pull request
4 tasks
corona10
added
skip news
topic-free-threading
and removed
awaiting core review
labels
Copy link Copy Markdown
Member Author
corona10
commented
Feb 23, 2024
corona10 commented
Feb 23, 2024To port list_ass_slice_impl from nogil implementation, we may need to port also other implementations but it occurs crash in my local so I need more investigation.
https://github.com/colesbury/nogil-3.12/blob/cedde4f5ec3759ad723c89d44738776f362df564/Objects/listobject.c#L101-L136
So before porting all of them, I propose a simpler implementation but not sure that it will be safe or acceptable performance. :)
corona10
requested a review
from colesbury
corona10
marked this pull request as draft
Copy link Copy Markdown
Member Author
corona10
commented
Feb 24, 2024
corona10 commented
Feb 24, 2024Hmm let me check more
Copy link Copy Markdown
Member Author
corona10
commented
Feb 24, 2024
corona10 commented
Feb 24, 2024I will continue to work on this PR after #115875 is merged.
corona10
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment