Home Original page

bpo-35283: Update the docstring of threading.Thread.join method by corona10 · Pull Request #11596 · python/cpython

Conversation

@corona10 corona10 changed the title bpo-35283: Update the docstring of threading.Thread.isAlive method bpo-35283: Update the docstring of threading.Thread.join method

Jan 17, 2019

@corona10

@vstinner @asvetlov
I found that the docstring of threading.Thread.join should be updated to use is_alive.
And also it needs to apply 3.x versions. What do you think?

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the NEWS entry. It's not worth it. I will add "skip news" label instead.

@corona10

@vstinner
I remove the NEWS entry as you comment.
Thanks always

eamanu

corona10 added a commit to corona10/cpython that referenced this pull request

Jan 18, 2019

Labels