gh-112075: Avoid locking shared keys on every assignment by DinoV · Pull Request #116087 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
DinoV merged 2 commits intopython:mainfrom
Feb 29, 2024Merged
gh-112075: Avoid locking shared keys on every assignment#116087
DinoV merged 2 commits intopython:mainfrom
gh-112075: Avoid locking shared keys on every assignment#116087
DinoV merged 2 commits intopython:mainfrom
Conversation
Copy link Copy Markdown
Contributor
Currently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead.
DinoV
requested a review
from colesbury
bedevere-app
bot
mentioned this pull request
DinoV
added
topic-free-threading
skip news
labels
DinoV
force-pushed
the
nogil_avoid_keys_lock_on_set
branch
from
af52498 to
22d7bfb
Compare
DinoV
marked this pull request as ready for review
DinoV
requested review from
markshannon and
methane
as code owners
bedevere-app
bot
added
the
awaiting core review
label
colesbury reviewed Feb 29, 2024
Objects/dictobject.c
Outdated
Show resolved
Hide resolved
Objects/dictobject.c Outdated Show resolved Hide resolved
Objects/dictobject.c
Outdated
Show resolved
Hide resolved
Objects/dictobject.c Outdated Show resolved Hide resolved
Objects/dictobject.c
Outdated
Show resolved
Hide resolved
Objects/dictobject.c Outdated Show resolved Hide resolved
…StoreInstanceAttribute
DinoV
force-pushed
the
nogil_avoid_keys_lock_on_set
branch
from
d6e97e9 to
8812f5b
Compare
colesbury approved these changes Feb 29, 2024
bedevere-app
bot
added
awaiting merge
and removed
awaiting core review
labels
DinoV
merged commit
556749c
into
python:main
bedevere-app
bot
removed
the
awaiting merge
label
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request
Mar 4, 2024
DinoV
mentioned this pull request
adorilson pushed a commit to adorilson/cpython that referenced this pull request
Mar 25, 2024diegorusso pushed a commit to diegorusso/cpython that referenced this pull request
Apr 17, 2024
DinoV
deleted the
nogil_avoid_keys_lock_on_set
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment