Home Original page

gh-112087: Make list.sort to be thread-safe for PEP 703. by corona10 · Pull Request #116553 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@corona10

Copy link Copy Markdown

Member

@corona10 corona10 commented

Mar 9, 2024

•

edited by bedevere-app bot

Loading

@corona10

Copy link Copy Markdown

Member Author

corona10 commented

Mar 9, 2024

  • No resizing in here
  • QSBR was already applied:

    cpython/Objects/listobject.c

    Lines 2854 to 2861 in 17d31bf

    #ifdef Py_GIL_DISABLED
    bool use_qsbr = _PyObject_GC_IS_SHARED(self);
    #else
    bool use_qsbr = false;
    #endif
    free_list_items(final_ob_item, use_qsbr);
    }
    return Py_XNewRef(result);

@corona10 corona10 changed the title gh-112087: Make list.sort to be threaf-safe for PEP 703. gh-112087: Make list.sort to be thread-safe for PEP 703.

Mar 10, 2024

@corona10 corona10 requested a review from colesbury

March 10, 2024 00:20

@corona10 corona10 enabled auto-merge (squash)

March 10, 2024 00:32

@corona10 corona10 merged commit 5b2f21f into python:main

Mar 10, 2024

@corona10 corona10 deleted the gh-112087-sort branch

March 10, 2024 01:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10 @colesbury