Home Original page

bpo-35843: Implement __getitem__ for _NamespacePath by asottile · Pull Request #11690 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@asottile

Copy link Copy Markdown

Contributor

@asottile asottile commented

Jan 28, 2019

•

edited by brettcannon

Loading

No description provided.

Copy link Copy Markdown

Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I re run the sample used on bpo https://bugs.python.org/issue35843 and have the expected behavior.

@asottile asottile force-pushed the bpo_35843_NamespacePath_Sized branch from 5550ff6 to 0de7e75 Compare

February 17, 2019 16:10

@asottile

Copy link Copy Markdown

Contributor Author

@serhiy-storchaka should be good to review again -- thanks for the tip 👍

@serhiy-storchaka

Copy link Copy Markdown

Member

I can say nothing about whether this idea is good or bad. But technically this PR looks correct.

@brettcannon

Copy link Copy Markdown

Member

I'm blocking this to see if any other core devs have an opinion on this on the issue tracker, otherwise it LGTM!

@asottile

Copy link Copy Markdown

Contributor Author

asottile commented

Mar 7, 2019

@brettcannon given the +1 in the bpo issue I think this is good to go

@brettcannon

Copy link Copy Markdown

Member

@asottile that's the plan 😄 Just need to find the time to handle the merge (probably tomorrow/Friday).

asottile reacted with heart emoji

@brettcannon

Copy link Copy Markdown

Member

Thanks, @asottile !

asottile reacted with hooray emoji

@asottile asottile deleted the bpo_35843_NamespacePath_Sized branch

March 8, 2019 19:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@brettcannon brettcannon brettcannon approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asottile @serhiy-storchaka @brettcannon @eamanu @the-knights-who-say-ni @bedevere-bot @miss-islington